svn commit: r327205 - head/sys/netinet/libalias
Michael Tuexen
tuexen at freebsd.org
Tue Dec 26 16:54:26 UTC 2017
> On 26. Dec 2017, at 17:00, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
>
> On Tue, Dec 26, 2017 at 03:24:42PM +0000, Michael Tuexen wrote:
>> New Revision: 327205
>> URL: https://svnweb.freebsd.org/changeset/base/327205
>>
>> Log:
>> Fix CID 1008936.
>
> I'm afraid this is a rather bad commit message. It should have described
> what was the problem and how it was approached (fixed). Listing CID is
> part of the metadata; it cannot replace proper commit log.
It replaced a comparison left side == right side with identical left
and right sides with the correct condition. I guess that was a copy and paste error.
>
> Also, please do not mix functional and substantial amount of style changes
> in a single commit.
Yepp. You are right. Will do in the future...
Best regards
Michael
>
> ./danfe
More information about the svn-src-all
mailing list