svn commit: r326923 - stable/10/usr.bin/calendar/calendars

[Baptiste Daroussin]

On Tue, Dec 19, 2017 at 10:04:21AM +1100, Greg 'groggy' Lehey wrote:
> On Monday, 18 December 2017 at 15:23:06 +0100, Baptiste Daroussin wrote:
> > On Sun, Dec 17, 2017 at 10:12:58PM +0000, Greg Lehey wrote:
> >> Author: grog
> >> Date: Sun Dec 17 22:12:57 2017
> >> New Revision: 326923
> >> URL: https://svnweb.freebsd.org/changeset/base/326923
> >>
> >> Log:
> >>   Correct character set.
> >
> > You are "correcting" a UTF-8 character into a ISO-8859 character directly in
> > branch 10.
> >
> > This looks wrong in multiple way:
> > 1. everything was converted into UTF-8 in 2011 on purpose
> 
> For small values of "everything", maybe.  I've checked three files:
> calendar.history, fr_FR.ISO8859-1/calendar.fetes and
> de_DE.ISO8859-1/calendar.geschichte.  Only the first was in UTF-8.
> 
> It sounds like a good idea to convert the files to UTF-8, but it has to be done
> to all of them.  And how about adding some information about the
> preferred character set?  We could kill two birds with one stone and
> add this to the top of each file:

Sorry I wasn't clear everything in that directory has been changed into UTF-8:
r228991

For subdirectories it is less a problem as LANG is defined in each files to
state the locale and then calendar(1) will itself switch to the defined locales.

That said nowaday, most of the users of non ASCII countries are using UTF-8
only so if it was me I would rename all the ISO8859* calendars into UTF-8 ones
and convert the locale to UTF-8. but hey :)

BApt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20171219/76a9fdd8/attachment.sig>