svn commit: r326614 - in head: etc/mtree usr.bin usr.bin/sponge usr.bin/tee

[Kyle Evans]

On Dec 8, 2017 8:07 PM, "Eitan Adler" <eadler at freebsd.org> wrote:

On 8 December 2017 at 12:11, Rodney W. Grimes
<freebsd at pdx.rh.cn85.dnsmgr.net> wrote:

> Ping, I have not seen this reverted and recommitted with a reasonable
> explination as to why this change is actually desired.

Sorry, work has been busy and as the crux was reverted it didn't feel
as urgent[0]. The answer is that shell scripts in scripts don't need
to be chmod +x to work. In fact most are not.
Of the tests I found from a simple search:
65 are chmod +x
84 are chmod -x

The entirety of the changed config is:
    "chmod": {
      "type": "chmod",
+      "exclude": "(/tests/)"
    },

which simply disables this test during 'arc diff'.


+1 to this change, but I think it would've been worthy of its own commit. I
don't recall off-hand if it's ATF-specific or not- in that case, at least,
the scripts are merely being processed into atf-sh script for when it ends
up in /usr/tests.

It's probably worth double checking the non-ATF case to make sure -x won't
break their expected execution, though.

- Kyle Evans