svn commit: r326664 - head/sys/vm

[Conrad Meyer]

Read the phab review.

On Thu, Dec 7, 2017 at 1:23 PM, Oliver Pinter
<oliver.pinter at hardenedbsd.org> wrote:
> On 12/7/17, Mark Johnston <markj at freebsd.org> wrote:
>> Author: markj
>> Date: Thu Dec  7 19:38:09 2017
>> New Revision: 326664
>> URL: https://svnweb.freebsd.org/changeset/base/326664
>>
>> Log:
>>   Fix the UMA reclaim worker after r326347.
>>
>>   atomic_set_*() sets a bit in the target memory location, so
>>   atomic_set_int(&uma_reclaim_needed, 0) does not do what it looks like
>>   it does.
>>
>>   PR:         224080
>>   Reviewed by:        jeff, kib
>>   Differential Revision:      https://reviews.freebsd.org/D13412
>>
>> Modified:
>>   head/sys/vm/uma_core.c
>>
>> Modified: head/sys/vm/uma_core.c
>> ==============================================================================
>> --- head/sys/vm/uma_core.c    Thu Dec  7 18:04:48 2017        (r326663)
>> +++ head/sys/vm/uma_core.c    Thu Dec  7 19:38:09 2017        (r326664)
>> @@ -3177,7 +3177,7 @@ uma_reclaim_worker(void *arg __unused)
>>               EVENTHANDLER_INVOKE(vm_lowmem, VM_LOW_KMEM);
>>               sx_xlock(&uma_drain_lock);
>>               uma_reclaim_locked(true);
>> -             atomic_set_int(&uma_reclaim_needed, 0);
>> +             uma_reclaim_needed = 0;
>
> atomic_store_rel_int(&uma_reclaim_needed, 0) ?
>
>>               sx_xunlock(&uma_drain_lock);
>>               /* Don't fire more than once per-second. */
>>               pause("umarclslp", hz);
>> _______________________________________________
>> svn-src-head at freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/svn-src-head
>> To unsubscribe, send any mail to "svn-src-head-unsubscribe at freebsd.org"
>>
>