svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee

[Devin Teske]

> On Dec 4, 2017, at 8:40 PM, Conrad Meyer <cem at freebsd.org> wrote:
> 
>> On Mon, Dec 4, 2017 at 8:30 PM, Conrad Meyer <cem at freebsd.org> wrote:
>>> On Mon, Dec 4, 2017 at 7:55 PM, Eitan Adler <eadler at freebsd.org> wrote:
>>> Author: eadler
>>> Date: Tue Dec  5 03:55:10 2017
>>> New Revision: 326554
>>> URL: https://svnweb.freebsd.org/changeset/base/326554
>>> 
>>> Log:
>>>  sponge(1): initial commit
>>> 
>>>  sponge(1) is a utility that reads input until
>>>  complete, then opens the output file, then
>>>  writes to it. This makes it useful in pipelines
>>>  that read and write to the same file.
>>> 
>>>  Reviewed by:  wblock, jilles, imp, cem, danfe (all: various iterations)
>> 
>> I don't recall reviewing this in any iteration, but I could be mistaken.
>> 
>> Best,
>> Conrad
> 
> In fact I don't think any of the listed reviewers approved the change,
> at least in phabricator.  The "Reviewed by" line signifies not just
> giving feedback, but approval of the final (or near-final) change.
> 
> Best,
> Conrad
> 

If true, upsetting. You have people like myself that are ultra patient and wait for the approvals. For example, https://reviews.freebsd.org/D10006 which has been in review for 8 months now and I have been working on it for a total of 5 years now.

It is more than a little hurtful to put in such effort and then see someone else run roughshod past the group.
-- 
Devin