svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee

[Li-Wen Hsu]

On Tue, Dec 05, 2017 at 10:43:45 +0200, Konstantin Belousov wrote:
> On Tue, Dec 05, 2017 at 03:55:10AM +0000, Eitan Adler wrote:
> > Author: eadler
> > Date: Tue Dec  5 03:55:10 2017
> > New Revision: 326554
> > URL: https://svnweb.freebsd.org/changeset/base/326554

[...]

> > Added: head/usr.bin/sponge/sponge.c
> > ==============================================================================
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/usr.bin/sponge/sponge.c	Tue Dec  5 03:55:10 2017	(r326554)

[...]

> > +	while (bufremain > 0) {
> > +		whichbuf = (bufremain < maxiovec) ? bufremain : maxiovec;
> > +		bufremain -= whichbuf;
> > +
> > +		i = writev(fd, iov, whichbuf);
> > +		if (i < 0) {
> > +			err(1, "failed to write");
> > +		}
> > +	}
> This loop is nonsensical.

Also breaks build:

/usr/src/usr.bin/sponge/sponge.c:175:25: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'long' [-Werror,-Wsign-compare]
                whichbuf = (bufremain < maxiovec) ? bufremain : maxiovec;
                            ~~~~~~~~~ ^ ~~~~~~~~
1 error generated.

Ref: https://ci.freebsd.org/job/FreeBSD-head-amd64-build/6187/console

Please check this.

Thanks,
Li-Wen

-- 
Li-Wen Hsu <lwhsu at FreeBSD.org>
https://lwhsu.org