svn commit: r322942 - head/sys/kern

Conrad Meyer cem at freebsd.org
Sun Aug 27 15:51:17 UTC 2017


On Sun, Aug 27, 2017 at 1:18 AM, Ed Schouten <ed at nuxi.nl> wrote:
> Hi Conrad,
>
> [ Context: I don't understand anything about CPU topologies! ]
>
> 2017-08-27 7:14 GMT+02:00 Conrad Meyer <cem at freebsd.org>:
>> +       while (top->cg_children == 1) {
>> +               top = &top->cg_child[0];
>> +               top->cg_parent = NULL;
>> +       }
>
> This only removes layers from the top if they only have a single
> child. Question: is it possible/likely to have CPU topologies where
> one of the middle layers only has one child? If so, would it make
> sense to use tree traversal here to do the flattening?

Hi Ed,

It is probably possible for middle layers to have a single child, and
your proposal is a good one.  This is just the canned patch from Jeff
I already had lying around :-).

Best,
Conrad


More information about the svn-src-all mailing list