svn commit: r322650 - head/sys/dev/safe

Ryan Libby rlibby at FreeBSD.org
Fri Aug 18 08:05:35 UTC 2017


Author: rlibby
Date: Fri Aug 18 08:05:33 2017
New Revision: 322650
URL: https://svnweb.freebsd.org/changeset/base/322650

Log:
  safe: quiet -Wtautological-compare
  
  Code was testing that an unsigned type was >= 0.
  
  Reviewed by:	markj
  Approved by:	markj (mentor)
  Sponsored by:	Dell EMC Isilon

Modified:
  head/sys/dev/safe/safe.c

Modified: head/sys/dev/safe/safe.c
==============================================================================
--- head/sys/dev/safe/safe.c	Fri Aug 18 07:34:34 2017	(r322649)
+++ head/sys/dev/safe/safe.c	Fri Aug 18 08:05:33 2017	(r322650)
@@ -1593,9 +1593,7 @@ safe_mcopy(struct mbuf *srcm, struct mbuf *dstm, u_int
 	 * Advance src and dst to offset.
 	 */
 	j = offset;
-	while (j >= 0) {
-		if (srcm->m_len > j)
-			break;
+	while (j >= srcm->m_len) {
 		j -= srcm->m_len;
 		srcm = srcm->m_next;
 		if (srcm == NULL)
@@ -1605,9 +1603,7 @@ safe_mcopy(struct mbuf *srcm, struct mbuf *dstm, u_int
 	slen = srcm->m_len - j;
 
 	j = offset;
-	while (j >= 0) {
-		if (dstm->m_len > j)
-			break;
+	while (j >= dstm->m_len) {
 		j -= dstm->m_len;
 		dstm = dstm->m_next;
 		if (dstm == NULL)


More information about the svn-src-all mailing list