svn commit: r321949 - head/bin/chmod/tests

Ngie Cooper ngie at FreeBSD.org
Wed Aug 2 21:18:56 UTC 2017


Author: ngie
Date: Wed Aug  2 21:18:54 2017
New Revision: 321949
URL: https://svnweb.freebsd.org/changeset/base/321949

Log:
  Add expected failures for ZFS
  
  - :f_flag fails on ZFS because UF_IMMUTABLE isn't supported [1].
  - :v_flag fails on ZFS because the mode for foo is [always] updated
    unnecessarily.
  
  get_filesystem(..) (supporting function that was added to the test script)
  is based on equivalent logic in usr.bin/extattr/tests/extattr_test.sh .
  
  MFC after:	1 week
  PR:	221189 [1], 221188 [2]

Modified:
  head/bin/chmod/tests/chmod_test.sh

Modified: head/bin/chmod/tests/chmod_test.sh
==============================================================================
--- head/bin/chmod/tests/chmod_test.sh	Wed Aug  2 21:11:51 2017	(r321948)
+++ head/bin/chmod/tests/chmod_test.sh	Wed Aug  2 21:18:54 2017	(r321949)
@@ -25,6 +25,11 @@
 #
 # $FreeBSD$
 
+get_filesystem()
+{
+	df -T . | tail -n 1 | cut -wf 2
+}
+
 atf_test_case RH_flag
 RH_flag_head()
 {
@@ -94,6 +99,11 @@ f_flag_body()
 {
 	atf_check truncate -s 0 foo bar
 	atf_check chmod 0750 foo bar
+	case "$(get_filesystem .)" in
+	zfs)
+		atf_expect_fail "ZFS doesn't support UF_IMMUTABLE; returns EPERM - bug 221189"
+		;;
+	esac
 	atf_check chflags uchg foo
 	atf_check -e not-empty -s not-exit:0 chmod 0700 foo bar
 	atf_check -o inline:'100750\n100700\n' stat -f '%p' foo bar
@@ -140,6 +150,11 @@ v_flag_body()
 	atf_check truncate -s 0 foo bar
 	atf_check chmod 0600 foo
 	atf_check chmod 0750 bar
+	case "$(get_filesystem .)" in
+	zfs)
+		atf_expect_fail "ZFS updates mode for foo unnecessarily - bug 221188"
+		;;
+	esac
 	atf_check -o 'inline:bar\n' chmod -v 0600 foo bar
 	atf_check chmod -v 0600 foo bar
 	for f in foo bar; do


More information about the svn-src-all mailing list