svn commit: r321877 - stable/10/sys/fs/nfs

Edward Tomasz Napierala trasz at FreeBSD.org
Tue Aug 1 15:51:18 UTC 2017


Author: trasz
Date: Tue Aug  1 15:51:16 2017
New Revision: 321877
URL: https://svnweb.freebsd.org/changeset/base/321877

Log:
  MFC r320359:
  
  Add vfs.nfsd.nfsd_enable_uidtostring, which works just like
  vfs.nfsd.nfsd_enable_stringtouid, but in reverse - when set to 1,
  it forces the NFSv4 server to return numeric UIDs and GIDs instead
  of "user at domain" strings. This helps with clients that can't
  translate returned identifiers, eg when rerooting.
  
  The same can be achieved by just never running nfsuserd(8),
  but the sysctl is useful to toggle the behaviour back and forth
  without rebooting.
  
  MFC r320409:
  
  Revert part of r320359, as suggested by rmacklem at .  That case is only used
  for nfsuserd -manage-gids and shouldn't depend on sysctl.
  
  MFC r321196:
  
  Rename vfs.nfsd.enable_uidtostring to vfs.nfs.enable_uidtostring.
  It applies to both NFS client and NFS server, and is useful for both.
  This is different from vfs.nfsd.enable_stringtouid, which is specific
  to server side.
  
  Sponsored by:	DARPA, AFRL

Modified:
  stable/10/sys/fs/nfs/nfs_commonsubs.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/fs/nfs/nfs_commonsubs.c
==============================================================================
--- stable/10/sys/fs/nfs/nfs_commonsubs.c	Tue Aug  1 14:54:25 2017	(r321876)
+++ stable/10/sys/fs/nfs/nfs_commonsubs.c	Tue Aug  1 15:51:16 2017	(r321877)
@@ -68,10 +68,15 @@ gid_t nfsrv_defaultgid = GID_NOGROUP;
 int nfsrv_lease = NFSRV_LEASE;
 int ncl_mbuf_mlen = MLEN;
 int nfsd_enable_stringtouid = 0;
+static int nfs_enable_uidtostring = 0;
 NFSNAMEIDMUTEX;
 NFSSOCKMUTEX;
 extern int nfsrv_lughashsize;
 
+SYSCTL_DECL(_vfs_nfs);
+SYSCTL_INT(_vfs_nfs, OID_AUTO, enable_uidtostring, CTLFLAG_RW,
+    &nfs_enable_uidtostring, 0, "Make nfs always send numeric owner_names");
+
 /*
  * This array of structures indicates, for V4:
  * retfh - which of 3 types of calling args are used
@@ -2576,7 +2581,7 @@ nfsv4_uidtostr(uid_t uid, u_char **cpp, int *retlenp, 
 
 	cnt = 0;
 tryagain:
-	if (nfsrv_dnsnamelen > 0) {
+	if (nfsrv_dnsnamelen > 0 && !nfs_enable_uidtostring) {
 		/*
 		 * Always map nfsrv_defaultuid to "nobody".
 		 */
@@ -2838,7 +2843,7 @@ nfsv4_gidtostr(gid_t gid, u_char **cpp, int *retlenp, 
 
 	cnt = 0;
 tryagain:
-	if (nfsrv_dnsnamelen > 0) {
+	if (nfsrv_dnsnamelen > 0 && !nfs_enable_uidtostring) {
 		/*
 		 * Always map nfsrv_defaultgid to "nogroup".
 		 */


More information about the svn-src-all mailing list