svn commit: r317409 - head/contrib/tcpdump

[Bryan Drewery]

On 4/25/2017 1:38 PM, Benjamin Kaduk wrote:
> On Tue, Apr 25, 2017 at 3:28 PM, John Baldwin <jhb at freebsd.org
> <mailto:jhb at freebsd.org>> wrote:
> 
> 
>     I do think that when referring to a Git hash the citation should
>     also include
>     something to identify which repository it came from.  It doesn't
>     have to be a
>     URL per se (we just use 'NetBSD' for makefs, not a full URL to NetBSD's
>     cvsweb), but it should be clear enough that one can find the
>     corresponding
>     repository.  Probably that information belongs in 'Obtained From'.
> 
> 
> Since Rodney asked and I already have the svn log up, here are some existing
> commits that are doing similar sorts of things:
> r317267 is typical of the illumos/ZFS imports
> though sometimes a full github URL is used, as in r316695
> r316665 pulls from Concurrency Kit (I think; CK was not expanded in the
> commit message :( )
> r315947 from libcxxrt
> r315926 and a few previous revisions from dragonflybsd.git
> r315745 from libcxxrt
> r314435 again from CK
> 
> and we're not even out of 2017 yet.
> 

Plus if tcpdump were using SVN then we would refer to an SVN revision
here. If it were using CVS then a CVS revision.  Like this commit in
FreeBSD:

> ------------------------------------------------------------------------
> r306349 | pfg | 2016-09-26 09:06:50 -0700 (Mon, 26 Sep 2016) | 7 lines
> Changed paths:
>    M /head/lib/libc/db/hash/hash_page.c
> 
> hash(3): protect in-memory page when using cross-endianness.
> 
> When writing out pages in the "other endian" format, make a copy
> instead of trashing the in-memory one.
> 
> Obtained from:  NetBSD (CVS rev. 1.29)
> 
> ------------------------------------------------------------------------


It is definitely more useful to note which repository and what VCS
system the revision/hash/version refers to.  But there's nothing
inherently wrong about using a git hash.  Github != git. It is merely an
interface to git and is not required to use any of the git repositories
on it given another mirror or local checkout.  If a project uses git as
their official VCS then a git hash is the proper reference.


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170425/c484233a/attachment.sig>