svn commit: r317290 - head/tools/regression/geom_gpt

[Rodney W. Grimes]

-- Start of PGP signed section.
[ Charset UTF-8 unsupported, converting... ]
> 
> > On Apr 22, 2017, at 13:06, Rodney W. Grimes <freebsd at pdx.rh.CN85.dnsmgr.net> wrote:
> > 
> >> Author: ngie
> >> Date: Sat Apr 22 20:00:52 2017
> >> New Revision: 317290
> >> URL: https://svnweb.freebsd.org/changeset/base/317290
> >> 
> >> Log:
> >>  Fix -Wimplicit-function-declaration compilation warning by moving libgeom.h
> >>  #include below the stdio.h #include.
> >> 
> >>  gctl_dump(3) needs stdio.h, per reasoning noted in r317289.
> >> 
> >>  MFC after:	5 weeks
> >>  PR:		218809
> >>  Submitted by:	Chang-Hsien Tsai <luke.tw at gmail.com>
> >>  Sponsored by:	Dell EMC Isilon
> >> 
> >> Modified:
> >>  head/tools/regression/geom_gpt/test.c
> >> 
> >> Modified: head/tools/regression/geom_gpt/test.c
> >> ==============================================================================
> >> --- head/tools/regression/geom_gpt/test.c	Sat Apr 22 19:32:23 2017	(r317289)
> >> +++ head/tools/regression/geom_gpt/test.c	Sat Apr 22 20:00:52 2017	(r317290)
> >> @@ -29,12 +29,12 @@ __FBSDID("$FreeBSD$");
> >> 
> >> #include <sys/param.h>
> >> #include <errno.h>
> >> -#include <libgeom.h>
> >> #include <limits.h>
> >> #include <stdio.h>
> >> #include <stdlib.h>
> >> #include <string.h>
> >> #include <unistd.h>
> >> +#include <libgeom.h>
> > #include <libgeom.h>	/* This is not in alphabetic order per r317289 */
> >> 
> >> struct retval {
> >> 	struct retval *retval;
> > 
> > Might it be a good idea to mark this in the test.c file as to why
> > these are not sorted in order to prevent regressions of this in
> > the future?
> 
> Please see r317289. There was an omission in the documentation that allowed this to happen.

I had seen that already when I made my post, that docuement is not going
to stop someone from going "Oh, these are out of order I am going to sort
them since I am here"  They well then probably have issues due to your next
statement about WARNS and go hum, what is that all about.  And either 
investigate and hopefully find the right thing, or do more wrong things.

When #includes are out of order for good reason the source code file should
be market as such and not dependend on the near 0 likelyhood someone
is going to go read a man page to find out why.

> 
> This also won?t happen again given that the test is now being compiled with WARNS?= 6 :).
> 
> -Ngie
-- End of PGP section, PGP failed!

-- 
Rod Grimes                                                 rgrimes at freebsd.org