svn commit: r316648 - in head/sys: amd64/amd64 amd64/include arm/arm arm/include arm64/include cddl/dev/dtrace/aarch64 cddl/dev/dtrace/amd64 cddl/dev/dtrace/arm cddl/dev/dtrace/i386 cddl/dev/dtrace...

[Patrick Kelsey]

On Mon, Apr 10, 2017 at 1:26 PM, Jung-uk Kim <jkim at freebsd.org> wrote:

> On 04/10/2017 13:23, Jung-uk Kim wrote:
> > On 04/08/2017 22:00, Patrick Kelsey wrote:
> >> Author: pkelsey
> >> Date: Sun Apr  9 02:00:03 2017
> >> New Revision: 316648
> >> URL: https://svnweb.freebsd.org/changeset/base/316648
> >>
> >> Log:
> >>   Corrected misspelled versions of rendezvous.
> >>
> >>   The MFC will include a compat definition of smp_no_rendevous_barrier()
> >>   that calls smp_no_rendezvous_barrier().
> >>
> >>   Reviewed by:       gnn, kib
> >>   MFC after: 1 week
> >>   Differential Revision:     https://reviews.freebsd.org/D10313
> > ...
> >
> > We knew about the problem but we didn't fix it because it breaks KPI.
> > For example, sysutils/virtualbox-ose-kmod.  If you really want to MFC
> > this change, you have to implement shims.
>
> Actually, I meant to say current also needs a shim.  Otherwise,
> _FreeBSD_version must be bumped.
>
> Sorry, I wasn't clear about this.
>
>
I'm glad you clarified, as I was reading your last message just now
wondering what I was missing.

With respect to current, the intention is for the misspelled version to be
gone in 12.  The lack of a version bump was due to my misunderstanding of
whether KPI changes were or weren't being tracked in __FreeBSD_version
prior to a .0 release, but now that I've gone and found 1.6 in the Porter's
Handbook, it's clear that they are.

Thanks for catching this.

-Patrick