svn commit: r316536 - in head: contrib/netbsd-tests/usr.bin/grep usr.bin/grep/tests

[Ngie Cooper (yaneurabeya)]

> On Apr 5, 2017, at 12:33, Kyle Evans <kevans91 at ksu.edu> wrote:
> 
> On Wed, Apr 5, 2017 at 1:48 PM, Ngie Cooper (yaneurabeya) <yaneurabeya at gmail.com> wrote:
> 
>         As a general rule of thumb, if it doesn’t pass, it needs to be marked as an expected failure until it passes. Not really a big deal right now (because ci.freebsd.org isn’t spamming current@ — yet), but when that switch gets thrown again, it would spam a few hundred people with known failures.
> 
> Ah, whoops. Something like this?
> 
>  diff --git a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
> index b8d2a398c8d..189e3547e34 100755
> --- a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
> +++ b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
> @@ -234,6 +234,7 @@ oflag_zerolen_head()
>  }
>  oflag_zerolen_body()
>  {
> +	atf_expect_fail "GNU grep's -o behavior with empty matches has known bugs (PR 195763)"
>  	atf_check -o file:"$(atf_get_srcdir)/d_oflag_zerolen_a.out" \
>  	    grep -Eo '(^|:)0*' "$(atf_get_srcdir)/d_oflag_zerolen_a.in"
> 
> @@ -281,6 +282,7 @@ color_body()
>  	atf_check -o file:"$(atf_get_srcdir)/d_color_b.out" \
>  	    grep --color=auto -f grepfile "$(atf_get_srcdir)/d_color_b.in"
> 
> +	atf_expect_fail "GNU grep --color output does not exactly match expectations going forward"
>  	atf_check -o file:"$(atf_get_srcdir)/d_color_c.out" \
>  	    grep --color=always -f grepfile "$(atf_get_srcdir)/d_color_b.in"
>  }
> 
> <grep-fail-tests.diff>

Yup!
-Ngie

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170405/65d6f529/attachment.sig>