svn commit: r316477 - head/usr.bin/grep

Kyle Evans kevans91 at ksu.edu
Tue Apr 4 13:55:41 UTC 2017


On Tue, Apr 4, 2017 at 8:53 AM, Ed Maste <emaste at freebsd.org> wrote:

> In this case I'd rather we remove the 00 and have the test verify
> that. I think it's fine if there are a few tests that fail when run
> with GNU grep where it has the undesired, differing behaviour.
>

Excellent- can you please revert this entire bit then:

@@ -474,13 +509,13 @@ printline(struct str *line, int sep, reg
                                fwrite(line->dat + a, matches[i].rm_so - a,
1,
                                    stdout);
                        if (color)
-                               fprintf(stdout, "\33[%sm\33[K", color);
+                               fprintf(stdout, "\33[%sm", color);

                                fwrite(line->dat + matches[i].rm_so,
                                    matches[i].rm_eo - matches[i].rm_so, 1,
                                    stdout);
                        if (color)
-                               fprintf(stdout, "\33[m\33[K");
+                               fprintf(stdout, "\33[00m\33[K");
                        a = matches[i].rm_eo;
                        if (oflag)
                                putchar('\n');

I'll address this in the unit tests review shortly.


More information about the svn-src-all mailing list