svn commit: r305998 - in head/usr.bin: cmp indent tr

Conrad Meyer cem at freebsd.org
Mon Sep 19 22:13:53 UTC 2016


If you re-read the sentences you've pasted carefully, I think you'll
find it doesn't actually say that the types or param headers come
before other sys/ headers.  Just that sys/ headers come before
non-sys/ headers.

Best,
Conrad

On Mon, Sep 19, 2016 at 1:45 PM, Ngie Cooper (yaneurabeya)
<yaneurabeya at gmail.com> wrote:
>
> On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer <cem at FreeBSD.org> wrote:
>
> Author: cem
> Date: Mon Sep 19 20:43:03 2016
> New Revision: 305998
> URL: https://svnweb.freebsd.org/changeset/base/305998
>
> Log:
>  Move sys/capsicum.h includes after types.h or param.h
>
>  This is not actually documented or even implied in style(9).  Make the
> change
>  to match convention.  Someone should document this convention in style(9).
>
>  Reported by: jhb
>  Sponsored by: EMC Dell Isilon
>
>
> Uh… yes it clearly states it in style(9). From
> https://www.freebsd.org/cgi/man.cgi?query=style&sektion=9 :
>
>      Kernel include files (i.e. sys/*.h) come first; normally, include
>      <sys/types.h> OR <sys/param.h>, but not both.  <sys/types.h> includes
>      <sys/cdefs.h>, and it is okay to depend on that.
>
> Thanks,
> -Ngie


More information about the svn-src-all mailing list