svn commit: r308143 - stable/10/contrib/libc++/include

Dimitry Andric dim at FreeBSD.org
Mon Oct 31 18:37:46 UTC 2016


Author: dim
Date: Mon Oct 31 18:37:44 2016
New Revision: 308143
URL: https://svnweb.freebsd.org/changeset/base/308143

Log:
  Pull in r228705 from upstream libc++ trunk (by Eric Fiselier):
  
    [libcxx] Fix PR 22468 - std::function<void()> does not accept
    non-void-returning functions
  
    Summary:
    The bug can be found here: https://llvm.org/bugs/show_bug.cgi?id=22468
  
    `__invoke_void_return_wrapper` is needed to properly handle calling a
    function that returns a value but where the std::function return type
    is void. Without this '-Wsystem-headers' will cause
    `function::operator()(...)` to not compile.
  
    Reviewers: eugenis, K-ballo, mclow.lists
  
    Reviewed By: mclow.lists
  
    Subscribers: cfe-commits
  
    Differential Revision: https://reviews.llvm.org/D7444
  
  This should allow newer versions of the graphics/aseprite port to
  compile without modification.
  
  Direct commit to stable/10, since stable/11 and head already have this
  change.
  
  Reported by:	yuri at rawbw.com
  PR:		213773

Modified:
  stable/10/contrib/libc++/include/__functional_03
  stable/10/contrib/libc++/include/__functional_base
  stable/10/contrib/libc++/include/__functional_base_03
  stable/10/contrib/libc++/include/functional

Modified: stable/10/contrib/libc++/include/__functional_03
==============================================================================
--- stable/10/contrib/libc++/include/__functional_03	Mon Oct 31 18:37:05 2016	(r308142)
+++ stable/10/contrib/libc++/include/__functional_03	Mon Oct 31 18:37:44 2016	(r308143)
@@ -369,7 +369,8 @@ template<class _Fp, class _Alloc, class 
 _Rp
 __func<_Fp, _Alloc, _Rp()>::operator()()
 {
-    return __invoke(__f_.first());
+    typedef __invoke_void_return_wrapper<_Rp> _Invoker;
+    return _Invoker::__call(__f_.first());
 }
 
 #ifndef _LIBCPP_NO_RTTI
@@ -452,7 +453,8 @@ template<class _Fp, class _Alloc, class 
 _Rp
 __func<_Fp, _Alloc, _Rp(_A0)>::operator()(_A0 __a0)
 {
-    return __invoke(__f_.first(), __a0);
+    typedef __invoke_void_return_wrapper<_Rp> _Invoker;
+    return _Invoker::__call(__f_.first(), __a0);
 }
 
 #ifndef _LIBCPP_NO_RTTI
@@ -535,7 +537,8 @@ template<class _Fp, class _Alloc, class 
 _Rp
 __func<_Fp, _Alloc, _Rp(_A0, _A1)>::operator()(_A0 __a0, _A1 __a1)
 {
-    return __invoke(__f_.first(), __a0, __a1);
+    typedef __invoke_void_return_wrapper<_Rp> _Invoker;
+    return _Invoker::__call(__f_.first(), __a0, __a1);
 }
 
 #ifndef _LIBCPP_NO_RTTI
@@ -618,7 +621,8 @@ template<class _Fp, class _Alloc, class 
 _Rp
 __func<_Fp, _Alloc, _Rp(_A0, _A1, _A2)>::operator()(_A0 __a0, _A1 __a1, _A2 __a2)
 {
-    return __invoke(__f_.first(), __a0, __a1, __a2);
+    typedef __invoke_void_return_wrapper<_Rp> _Invoker;
+    return _Invoker::__call(__f_.first(), __a0, __a1, __a2);
 }
 
 #ifndef _LIBCPP_NO_RTTI

Modified: stable/10/contrib/libc++/include/__functional_base
==============================================================================
--- stable/10/contrib/libc++/include/__functional_base	Mon Oct 31 18:37:05 2016	(r308142)
+++ stable/10/contrib/libc++/include/__functional_base	Mon Oct 31 18:37:44 2016	(r308143)
@@ -419,6 +419,26 @@ struct __invoke_return
     typedef decltype(__invoke(_VSTD::declval<_Tp>(), _VSTD::declval<_Args>()...)) type;
 };
 
+template <class _Ret>
+struct __invoke_void_return_wrapper
+{
+    template <class ..._Args>
+    static _Ret __call(_Args&&... __args)
+    {
+        return __invoke(_VSTD::forward<_Args>(__args)...);
+    }
+};
+
+template <>
+struct __invoke_void_return_wrapper<void>
+{
+    template <class ..._Args>
+    static void __call(_Args&&... __args)
+    {
+        __invoke(_VSTD::forward<_Args>(__args)...);
+    }
+};
+
 template <class _Tp>
 class _LIBCPP_TYPE_VIS_ONLY reference_wrapper
     : public __weak_result_type<_Tp>

Modified: stable/10/contrib/libc++/include/__functional_base_03
==============================================================================
--- stable/10/contrib/libc++/include/__functional_base_03	Mon Oct 31 18:37:05 2016	(r308142)
+++ stable/10/contrib/libc++/include/__functional_base_03	Mon Oct 31 18:37:44 2016	(r308143)
@@ -995,6 +995,63 @@ struct __invoke_return2
                                                     _VSTD::declval<_A2>())) type;
 };
 
+template <class _Ret>
+struct __invoke_void_return_wrapper
+{
+    template <class _Fn>
+    static _Ret __call(_Fn __f)
+    {
+        return __invoke(__f);
+    }
+
+    template <class _Fn, class _A0>
+    static _Ret __call(_Fn __f, _A0& __a0)
+    {
+        return __invoke(__f, __a0);
+    }
+
+    template <class _Fn, class _A0, class _A1>
+    static _Ret __call(_Fn __f, _A0& __a0, _A1& __a1)
+    {
+        return __invoke(__f, __a0, __a1);
+    }
+
+    template <class _Fn, class _A0, class _A1, class _A2>
+    static _Ret __call(_Fn __f, _A0& __a0, _A1& __a1, _A2& __a2)
+    {
+        return __invoke(__f, __a0, __a1, __a2);
+    }
+};
+
+
+template <>
+struct __invoke_void_return_wrapper<void>
+{
+    template <class _Fn>
+    static void __call(_Fn __f)
+    {
+        __invoke(__f);
+    }
+
+    template <class _Fn, class _A0>
+    static void __call(_Fn __f, _A0& __a0)
+    {
+        __invoke(__f, __a0);
+    }
+
+    template <class _Fn, class _A0, class _A1>
+    static void __call(_Fn __f, _A0& __a0, _A1& __a1)
+    {
+        __invoke(__f, __a0, __a1);
+    }
+
+    template <class _Fn, class _A0, class _A1, class _A2>
+    static void __call(_Fn __f, _A0& __a0, _A1& __a1, _A2& __a2)
+    {
+        __invoke(__f, __a0, __a1, __a2);
+    }
+};
+
 template <class _Tp>
 class _LIBCPP_TYPE_VIS_ONLY reference_wrapper
     : public __weak_result_type<_Tp>

Modified: stable/10/contrib/libc++/include/functional
==============================================================================
--- stable/10/contrib/libc++/include/functional	Mon Oct 31 18:37:05 2016	(r308142)
+++ stable/10/contrib/libc++/include/functional	Mon Oct 31 18:37:44 2016	(r308143)
@@ -1367,7 +1367,8 @@ template<class _Fp, class _Alloc, class 
 _Rp
 __func<_Fp, _Alloc, _Rp(_ArgTypes...)>::operator()(_ArgTypes&& ... __arg)
 {
-    return __invoke(__f_.first(), _VSTD::forward<_ArgTypes>(__arg)...);
+    typedef __invoke_void_return_wrapper<_Rp> _Invoker;
+    return _Invoker::__call(__f_.first(), _VSTD::forward<_ArgTypes>(__arg)...);
 }
 
 #ifndef _LIBCPP_NO_RTTI
@@ -1429,7 +1430,7 @@ class _LIBCPP_TYPE_VIS_ONLY function<_Rp
     template <class _Fp>
         struct __callable<_Fp, true>
         {
-            static const bool value =
+            static const bool value = is_same<void, _Rp>::value ||
                 is_convertible<typename __invoke_of<_Fp&, _ArgTypes...>::type,
                                _Rp>::value;
         };


More information about the svn-src-all mailing list