svn commit: r306346 - head/sys/kern

Eric van Gyzen vangyzen at FreeBSD.org
Sat Oct 15 15:10:57 UTC 2016


On 10/04/2016 15:56, Gleb Smirnoff wrote:
>   Eric,
>
> E> @@ -924,7 +924,7 @@ __mtx_assert(const volatile uintptr_t *c
> E>  {
> E>  	const struct mtx *m;
> E>  
> E> -	if (panicstr != NULL || dumping)
> E> +	if (panicstr != NULL || dumping || SCHEDULER_STOPPED())
> E>  		return;
>
> I wonder if all this disjunct can be reduced just to SCHEDULER_STOPPED()?
> Positive panicstr and dumping imply scheduler stopped.

If I read correctly, that's /almost/ true, but the scheduler is only stopped
#ifdef SMP and we're panicking, so we need the full expression to cover the !SMP
and reboot(RB_DUMP) cases.

Eric


More information about the svn-src-all mailing list