svn commit: r307236 - head/sys/vm

[Mark Johnston]

On Thu, Oct 13, 2016 at 01:49:29PM -0700, Conrad Meyer wrote:
> On Thu, Oct 13, 2016 at 1:39 PM, Mark Johnston <markj at freebsd.org> wrote:
> > Author: markj
> > Date: Thu Oct 13 20:39:34 2016
> > New Revision: 307236
> > URL: https://svnweb.freebsd.org/changeset/base/307236
> >
> > Log:
> >   Plug a potential vnode lock leak in vm_fault_hold().
> 
> This isn't just potential, right?  I believe we hit this one
> empirically with an assert in place of this if/vput.

Sorry, right, that was bad wording. I meant that the lock is not always
leaked in this error path - the map lookup needs to succeed initially,
after which we need to block for the vnode lock, restart the fault
handler, and then get an error from vm_map_lookup(). If the initial
lookup fails, there's no leak.