svn commit: r309121 - head/usr.sbin/bhyve

[Ian Lepore]

On Thu, 2016-11-24 at 23:27 +0100, Jakub Klama wrote:
> > 
> > Wiadomość napisana przez Ian Lepore <ian at FreeBSD.org> w dniu
> > 24.11.2016, o godz. 23:23:
> > 
> > On Thu, 2016-11-24 at 22:16 +0000, Jakub Wojciech Klama wrote:
> > > 
> > > Author: jceel
> > > Date: Thu Nov 24 22:16:18 2016
> > > New Revision: 309121
> > > URL: https://svnweb.freebsd.org/changeset/base/309121
> > > 
> > > Log:
> > >  virtio_console: handle short writes to an Unix domain socket
> > > gracefully.
> > > 
> > >  writev() can do a short write.  Retrying it results in a very
> > > convoluted
> > >  and complex code, so we iterate over iovec and do regular
> > > stream_write()
> > >  instead.
> > > 
> > Doesn't pwritev(2) simplify iterating to handle short writes?
> > 
> Correct me if I'm wrong, but pwritev(2) is a writev(2) with offset.
> We're writing to an Unix domain socket here, which is not seekable.
> 
> Thanks,
> Jakub
> 
> 

My bad, I was under the impression the offset was an offset into the
iovec, not into the file.  So, ummm... nevermind. :)

-- Ian