svn commit: r309109 - head/lib/libutil

[John Baldwin]

On Thursday, November 24, 2016 02:50:21 PM Dag-Erling Smørgrav wrote:
> Author: des
> Date: Thu Nov 24 14:50:21 2016
> New Revision: 309109
> URL: https://svnweb.freebsd.org/changeset/base/309109
> 
> Log:
>   Add a warning against modifying this code without understanding it, and
>   an example of how not to make it more portable.  I've had this lying
>   around uncommitted since 2009...

While I think the sentiment is correct, I would suggest adjusting the comment
as some folks may not get the sarcasm on first blush.  Even though it somewhat
duplicates the revision log, I think it would be useful to expand the comment
to list some of the "obvious" improvements to this function that actually
break it along with a brief explanation of the breakage each of these changes
cause.  In particular, the code here doesn't explain why close-on-exec would
be bad, but a comment as I've described would.

-- 
John Baldwin