svn commit: r309109 - head/lib/libutil

[Marcelo Araujo]

On Nov 25, 2016 12:27 AM, "Dag-Erling Smørgrav" <des at des.no> wrote:
>
> Marcelo Araujo <araujobsdport at gmail.com> writes:
> > We have code review, we have some many ways for communication, even
> > revert a commit if needed.
>
> No.  This is the kind of mistake where the code will seem to work just
> fine and end up in a release before a user suddenly discovers that they
> have two instances of the same daemon running and trashing their data.
> If I remember correctly, the last time someone touched flopen(),
> everything worked except 'service mountd reload' stopped working.
>
> > Everybody can read the svn history.
>
> Yeah, but they don't.  And before you say MAINTAINERS, they don't read
> or respect that either.  Believe me, I have years of experience cleaning
> up after unapproved, unreviewed commits to code I maintain.  Conversely,
> another committer once reverted a commit they had reviewed and approved
> because they thought I hadn't committed it and hit 'y' blindly when
> patch told them it was already applied.
>
> DES
> --
> Dag-Erling Smørgrav - des at des.no

Ok, I understand your frustration,  and I apologize about my previous
email, but you are a developer that most of people respect in this
community. You definitely has voice to solve it in a different way.

Best,