svn commit: r308848 - head/sbin/nvmecontrol

Warner Losh imp at FreeBSD.org
Sat Nov 19 17:14:33 UTC 2016


Author: imp
Date: Sat Nov 19 17:12:28 2016
New Revision: 308848
URL: https://svnweb.freebsd.org/changeset/base/308848

Log:
  Remove check for valid log pages. Let the drive tell us which pages
  are valid or not. While many pages are reserved in the standard, that
  doesn't make them invalid and future versions of the standard may
  define then.
  
  Sponsored by: Netflix, Inc

Modified:
  head/sbin/nvmecontrol/logpage.c

Modified: head/sbin/nvmecontrol/logpage.c
==============================================================================
--- head/sbin/nvmecontrol/logpage.c	Sat Nov 19 17:12:24 2016	(r308847)
+++ head/sbin/nvmecontrol/logpage.c	Sat Nov 19 17:12:28 2016	(r308848)
@@ -262,14 +262,6 @@ logpage(int argc, char *argv[])
 				    "\"%s\" not valid log page id.\n",
 				    optarg);
 				logpage_usage();
-			/* TODO: Define valid log page id ranges in nvme.h? */
-			} else if (log_page == 0 ||
-				   (log_page >= 0x04 && log_page <= 0x7F) ||
-				   (log_page >= 0x80 && log_page <= 0xBF)) {
-				fprintf(stderr,
-				    "\"%s\" not valid log page id.\n",
-				    optarg);
-				logpage_usage();
 			}
 			pageflag = true;
 			break;


More information about the svn-src-all mailing list