svn commit: r308819 - in head/sys/arm: conf ti/omap4 ti/omap4/pandaboard ti/usb

Andrew Turner andrew at fubar.geek.nz
Sat Nov 19 10:49:47 UTC 2016


On Sat, 19 Nov 2016 00:55:46 +0000 (UTC)
Olivier Houchard <cognet at FreeBSD.org> wrote:
...
> @@ -265,6 +269,16 @@ omap_ehci_probe(device_t dev)
>  	if (!ofw_bus_is_compatible(dev, "ti,ehci-omap"))
>  		return (ENXIO);
>  
> +#ifdef SOC_OMAP4
> +	/* 
> +	 * If we're running a Pandaboard, run Pandaboard-specific 
> +	 * init code.
> +	 */
> +	root = OF_finddevice("/");
> +	if (fdt_is_compatible(root, "ti,omap4-panda"))
> +		pandaboard_usb_hub_init();
> +#endif

Shouldn't this be in the attach function? It should also use
ofw_bus_node_is_compatible as I'm about to remove fdt_is_compatible.

Andrew


More information about the svn-src-all mailing list