svn commit: r300718 - in head/sys: kern sys

Hans Petter Selasky hps at selasky.org
Fri May 27 07:39:07 UTC 2016


On 05/26/16 23:37, Gleb Smirnoff wrote:
>   Hans,
>
> On Thu, May 26, 2016 at 08:41:55AM +0000, Hans Petter Selasky wrote:
> H> Author: hselasky
> H> Date: Thu May 26 08:41:55 2016
> H> New Revision: 300718
> H> URL: https://svnweb.freebsd.org/changeset/base/300718
> H>
> H> Log:
> H>   Add support for boolean sysctl's.
> H>
> H>   Because the size of bool can be implementation defined, make a bool
> H>   sysctl handler which handle bools. Userspace sees the bools like
> H>   unsigned 8-bit integers. Values are filtered to either 1 or 0 upon
> H>   read and write, similar to what a compiler would do.
> H>
> H>   Requested by:	kmacy @
> H>   Sponsored by:	Mellanox Technologies
>
> Would be nice if sysctl(8) would explicitly display them as "true" or "false"
> instead of 0 and 1. Now the userland can't differ them from uint8_t oids.
>

Hi,

We cannot use the "bool" type in userspace at least, because 
sizeof(bool) depends on the compiler. So the interface must use an 
integer type at least, possibly uint8_t like now.

Your suggestion makes sense. I'll look at some existing patches 
extending sysctl and test and make one for bool.

--HPS


More information about the svn-src-all mailing list