svn commit: r300773 - in head/sys: crypto crypto/aesni crypto/sha2 crypto/siphash kern sys

[Ngie Cooper]

On Thu, May 26, 2016 at 7:35 PM, Allan Jude <allanjude at freebsd.org> wrote:
> On 2016-05-26 15:29, Conrad E. Meyer wrote:
>> Author: cem
>> Date: Thu May 26 19:29:29 2016
>> New Revision: 300773
>> URL: https://svnweb.freebsd.org/changeset/base/300773
>>
>> Log:
>>   crypto routines: Hint minimum buffer sizes to the compiler
>>
>>   Use the C99 'static' keyword to hint to the compiler IVs and output digest
>>   sizes.  The keyword informs the compiler of the minimum valid size for a given
>>   array.  Obviously not every pointer can be validated (i.e., the compiler can
>>   produce false negative but not false positive reports).
>>
>>   No functional change.  No ABI change.
>>
>>   Sponsored by:       EMC / Isilon Storage Division

...

> This seems to have broken on sparc64, and other gcc based arches:
>
> ===> lib/libc (obj,all,install)
> In file included from /usr/src/lib/libc/../libmd/md5.h:40,
>                  from /usr/src/lib/libc/../libmd/md5c.c:42:
> /usr/obj/sparc64.sparc64/usr/src/tmp/usr/include/sys/md5.h:47:
> error: static or type qualifiers in abstract declarator
> --- md5c.o ---
> *** [md5c.o] Error code 1

I was wondering about that in the original commit. It might be a good
idea to revert both commits and reintroduce them with another keyword
(i.e. __static, or something in sys/cdefs.h )
Thanks,
-Ngie