svn commit: r300258 - head/sys/dev/iicbus

[Ravi Pokala]

-----Original Message-----
From: Jason Harmening <jason.harmening at gmail.com>
Date: 2016-05-19, Thursday at 21:05
To: Ravi Pokala <rpokala at mac.com>, "Jason A. Harmening" <jah at FreeBSD.org>, <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
Subject: Re: svn commit: r300258 - head/sys/dev/iicbus

>On 05/19/16 20:50, Ravi Pokala wrote:
>> -----Original Message-----
>> From: <owner-src-committers at freebsd.org> on behalf of "Jason A. Harmening" <jah at FreeBSD.org>
>> Date: 2016-05-19, Thursday at 20:03
>> To: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
>> Subject: svn commit: r300258 - head/sys/dev/iicbus
>> 
>> Hi Jason,
>> 
>> If I’m reading that right, it’s not preventing any allocations, but it is preventing a leak. Is that correct?
>> 
>> Thanks,
>> 
>> Ravi (rpokala@)
>
>Hi Ravi,
>
>There shouldn't be a leak in here, but checking the result prevents
>falling through the rest of the function, including the unnecessary
>malloc of usrbufs right after this.

How did I miss that earlier? Time for new glasses! :-P

>It also makes the error handling clearer.

Yeah.

>Thanks,
>Jason

Thank *you*,

Ravi (rpokala@)