svn commit: r299920 - head/sys/dev/sfxge/common

Andrew Rybchenko arybchik at FreeBSD.org
Mon May 16 08:04:42 UTC 2016


Author: arybchik
Date: Mon May 16 08:04:40 2016
New Revision: 299920
URL: https://svnweb.freebsd.org/changeset/base/299920

Log:
  sfxge(4): cleanup: simplify ef10_ev_qcreate
  
  Submitted by:   Andy Moreton <amoreton at solarflare.com>
  Sponsored by:   Solarflare Communications, Inc.
  MFC after:      1 week

Modified:
  head/sys/dev/sfxge/common/ef10_ev.c

Modified: head/sys/dev/sfxge/common/ef10_ev.c
==============================================================================
--- head/sys/dev/sfxge/common/ef10_ev.c	Mon May 16 07:47:20 2016	(r299919)
+++ head/sys/dev/sfxge/common/ef10_ev.c	Mon May 16 08:04:40 2016	(r299920)
@@ -92,8 +92,7 @@ efx_mcdi_init_evq(
 	__in		unsigned int instance,
 	__in		efsys_mem_t *esmp,
 	__in		size_t nevs,
-	__in		uint32_t irq,
-	__out_opt	uint32_t *irqp)
+	__in		uint32_t irq)
 {
 	efx_mcdi_req_t req;
 	uint8_t payload[
@@ -175,8 +174,7 @@ efx_mcdi_init_evq(
 		goto fail3;
 	}
 
-	if (irqp != NULL)
-		*irqp = MCDI_OUT_DWORD(req, INIT_EVQ_OUT_IRQ);
+	/* NOTE: ignore the returned IRQ param as firmware does not set it. */
 
 	return (0);
 
@@ -275,12 +273,9 @@ ef10_ev_qcreate(
 	eep->ee_drv_gen	= ef10_ev_drv_gen;
 	eep->ee_mcdi	= ef10_ev_mcdi;
 
-	/*
-	 * Set up the event queue
-	 * NOTE: ignore the returned IRQ param as firmware does not set it.
-	 */
+	/* Set up the event queue */
 	irq = index;	/* INIT_EVQ expects function-relative vector number */
-	if ((rc = efx_mcdi_init_evq(enp, index, esmp, n, irq, NULL)) != 0)
+	if ((rc = efx_mcdi_init_evq(enp, index, esmp, n, irq)) != 0)
 		goto fail3;
 
 	return (0);


More information about the svn-src-all mailing list