svn commit: r299770 - head/usr.sbin/bsnmpd/tools/libbsnmptools

Garrett Cooper ngie at FreeBSD.org
Sat May 14 22:43:09 UTC 2016


Author: ngie
Date: Sat May 14 22:43:07 2016
New Revision: 299770
URL: https://svnweb.freebsd.org/changeset/base/299770

Log:
  Fix up r299764
  
  I meant to use nitems, not sizeof(..) with the destination buffer. Using sizeof(..)
  on a pointer will always truncate the output in the destination buffer incorrectly
  
  Pointyhat to: ngie
  MFC after: 1 week
  X-MFC with: r299764
  Sponsored by: EMC / Isilon Storage Division

Modified:
  head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c

Modified: head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c
==============================================================================
--- head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c	Sat May 14 22:40:35 2016	(r299769)
+++ head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c	Sat May 14 22:43:07 2016	(r299770)
@@ -264,7 +264,7 @@ add_filename(struct snmp_toolinfo *snmpt
 
 	if (cut != NULL)
 		asn_append_oid(&(entry->cut), cut);
-	strlcpy(fstring, filename, sizeof(fstring));
+	strlcpy(fstring, filename, nitems(fstring));
 	entry->name = fstring;
 	entry->done = done;
 	SLIST_INSERT_HEAD(&snmptoolctx->filelist, entry, link);


More information about the svn-src-all mailing list