svn commit: r299682 - head/usr.sbin/i2c

Pedro F. Giffuni pfg at FreeBSD.org
Fri May 13 15:57:57 UTC 2016


Author: pfg
Date: Fri May 13 15:57:55 2016
New Revision: 299682
URL: https://svnweb.freebsd.org/changeset/base/299682

Log:
  i2c(8): uninitialized variable (UNINIT).
  
  If i2c_opt.width is somehow zero, buf will be left uninitialized and may
  cause trouble later on. This is a followup to r299586.
  
  CID:	1331548

Modified:
  head/usr.sbin/i2c/i2c.c

Modified: head/usr.sbin/i2c/i2c.c
==============================================================================
--- head/usr.sbin/i2c/i2c.c	Fri May 13 15:32:16 2016	(r299681)
+++ head/usr.sbin/i2c/i2c.c	Fri May 13 15:57:55 2016	(r299682)
@@ -294,8 +294,10 @@ i2c_write(char *dev, struct options i2c_
 			err_msg = "error: offset malloc";
 			goto err1;
 		}
-	} else
+	} else {
 		bufsize = 0;
+		buf = NULL;
+	}
 
 	switch(i2c_opt.mode) {
 	case I2C_MODE_STOP_START:


More information about the svn-src-all mailing list