svn commit: r299466 - head/contrib/bsnmp/snmpd

Conrad E. Meyer cem at FreeBSD.org
Wed May 11 17:06:04 UTC 2016


Author: cem
Date: Wed May 11 17:06:03 2016
New Revision: 299466
URL: https://svnweb.freebsd.org/changeset/base/299466

Log:
  bsnmpd: Fix size of trapsink::comm to match other community arrays
  
  This fixes a number of possible strcpy() buffer overruns between the various
  community strings in trap.c.
  
  Reported by:	Coverity
  CIDs:		1006820, 1006821, 1006822
  Sponsored by:	EMC / Isilon Storage Division

Modified:
  head/contrib/bsnmp/snmpd/snmpd.h

Modified: head/contrib/bsnmp/snmpd/snmpd.h
==============================================================================
--- head/contrib/bsnmp/snmpd/snmpd.h	Wed May 11 16:54:34 2016	(r299465)
+++ head/contrib/bsnmp/snmpd/snmpd.h	Wed May 11 17:06:03 2016	(r299466)
@@ -307,7 +307,7 @@ struct trapsink {
 	struct asn_oid	index;
 	u_int		status;
 	int		socket;
-	u_char		comm[SNMP_COMMUNITY_MAXLEN];
+	u_char		comm[SNMP_COMMUNITY_MAXLEN + 1];
 	int		version;
 };
 enum {


More information about the svn-src-all mailing list