svn commit: r299363 - head/sys/compat/linuxkpi/common/include/asm

[Hans Petter Selasky]

On 05/10/16 18:05, Conrad Meyer wrote:
> On Tue, May 10, 2016 at 8:55 AM, John Baldwin <jhb at freebsd.org> wrote:
>> On Tuesday, May 10, 2016 05:06:08 PM Hans Petter Selasky wrote:
>>> On 05/10/16 13:39, Hans Petter Selasky wrote:
>>>> Author: hselasky
>>>> Date: Tue May 10 11:39:36 2016
>>>> New Revision: 299363
>>>> URL: https://svnweb.freebsd.org/changeset/base/299363
>>>>
>>>> Log:
>>>>   Use function macros when possible to avoid stray substitutions.
>>>>
>>>>   MFC after:        1 week
>>>>   Sponsored by:     Mellanox Technologies
>>>>
>>
>> Is the reason for the change to avoid accepting the wrong number of arguments
>> (e.g. cpu_to_be32(x, y))?  Won't that still fail to compile if so?  (That is,
>> the reasoning for why you made the original change isn't clear to me from the
>> commit.)
>
> The macro form also prevents clobbering non-function-pointer variables
> named "cpu_to_be32," right?  Not that that's a great variable name.
>

Hi,

That's right Conrad. My intention was to avoid substitutions outside the 
function domain, like in a structure like this for example:

struct {
	int cpu_to_be32;
} xxx;

These functions only accepts one argument, so no problem there.

--HPS