svn commit: r299108 - head/sys/sys

[Adrian Chadd]

oops! sorry!


-a


On 4 May 2016 at 20:17, John Baldwin <jhb at freebsd.org> wrote:
> On Thursday, May 05, 2016 02:51:31 AM Garrett Cooper wrote:
>> Author: ngie
>> Date: Thu May  5 02:51:31 2016
>> New Revision: 299108
>> URL: https://svnweb.freebsd.org/changeset/base/299108
>>
>> Log:
>>   Revert r299096
>>
>>   The change broke buildworld when building lib/libkvm
>>
>>   This change likely needs to be run through a ports -exp run as a sanity
>>   check, as it might break downstream consumers.
>>
>>   Pointyhat to: adrian
>>   Reported by: kargl (confirmed on $work workstation)
>>   Sponsored by: EMC / Isilon Storage Division
>
> 'struct foo *' can be use with a simple forward declare in headers without
> requiring header pollution (and is often done for that reason).  device_t
> should be used in any .c files, but headers might need to stick with
> 'struct device *' in a few cases for that reason.  I suspect both of these
> fall into that category.
>
> --
> John Baldwin
>