svn commit: r297147 - head/lib/libstand

Ian Lepore ian at FreeBSD.org
Mon Mar 21 14:21:33 UTC 2016


Author: ian
Date: Mon Mar 21 14:21:32 2016
New Revision: 297147
URL: https://svnweb.freebsd.org/changeset/base/297147

Log:
  Garbage collect the bswap routines from libstand.  The declaration was
  wrapped in an i386 ifdef with a comment questioning their usefulness even
  there.  It turns out they aren't referenced anywhere, but their presence
  prevents using sys/endian.h in libstand code.
  
  These days, sys/endian.h provides much better support for such things, using
  compiler builtins and inline functions (and creating connections between
  libstand code and header files from sys/ would not be breaking new ground).

Modified:
  head/lib/libstand/Makefile
  head/lib/libstand/stand.h

Modified: head/lib/libstand/Makefile
==============================================================================
--- head/lib/libstand/Makefile	Mon Mar 21 08:30:58 2016	(r297146)
+++ head/lib/libstand/Makefile	Mon Mar 21 14:21:32 2016	(r297147)
@@ -25,7 +25,7 @@ WARNS?=		0
 CFLAGS+= -I${LIBSTAND_SRC}
 
 # standalone components and stuff we have modified locally
-SRCS+=	gzguts.h zutil.h __main.c assert.c bcd.c bswap.c environment.c getopt.c gets.c \
+SRCS+=	gzguts.h zutil.h __main.c assert.c bcd.c environment.c getopt.c gets.c \
 	globals.c pager.c printf.c strdup.c strerror.c strtol.c strtoul.c random.c \
 	sbrk.c twiddle.c zalloc.c zalloc_malloc.c
 

Modified: head/lib/libstand/stand.h
==============================================================================
--- head/lib/libstand/stand.h	Mon Mar 21 08:30:58 2016	(r297146)
+++ head/lib/libstand/stand.h	Mon Mar 21 14:21:32 2016	(r297147)
@@ -335,11 +335,6 @@ static __inline quad_t qmin(quad_t a, qu
 static __inline u_long ulmax(u_long a, u_long b) { return (a > b ? a : b); }
 static __inline u_long ulmin(u_long a, u_long b) { return (a < b ? a : b); }
 
-/* swaps (undocumented, useful?) */
-#ifdef __i386__
-extern u_int32_t	bswap32(u_int32_t x);
-extern u_int64_t	bswap64(u_int64_t x);
-#endif
 
 /* null functions for device/filesystem switches (undocumented) */
 extern int	nodev(void);


More information about the svn-src-all mailing list