svn commit: r296511 - vendor-sys/illumos/dist/uts/common/fs/zfs

Alexander Motin mav at FreeBSD.org
Tue Mar 8 17:29:58 UTC 2016


Author: mav
Date: Tue Mar  8 17:29:57 2016
New Revision: 296511
URL: https://svnweb.freebsd.org/changeset/base/296511

Log:
  6537 Panic on zpool scrub with DEBUG kernel
  
  Reviewed by: Steve Gonczi <gonczi at comcast.net>
  Reviewed by: Dan McDonald <danmcd at omniti.com>
  Reviewed by: Igor Kozhukhov <ikozhukhov at gmail.com>
  Reviewed by: Matthew Ahrens <mahrens at delphix.com>
  Approved by: Matthew Ahrens <mahrens at delphix.com>
  Author: Gary Mills <gary_mills at fastmail.fm>
  
  illumos/illumos-gate at 8c04a1fa3f7d569d48fe9b5342d0bd4c533179b9

Modified:
  vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_scan.c

Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_scan.c
==============================================================================
--- vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_scan.c	Tue Mar  8 17:27:13 2016	(r296510)
+++ vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_scan.c	Tue Mar  8 17:29:57 2016	(r296511)
@@ -21,6 +21,7 @@
 /*
  * Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
  * Copyright (c) 2011, 2015 by Delphix. All rights reserved.
+ * Copyright 2016 Gary Mills
  */
 
 #include <sys/dsl_scan.h>
@@ -1517,7 +1518,8 @@ dsl_scan_sync(dsl_pool_t *dp, dmu_tx_t *
 	}
 	if (err != 0)
 		return;
-	if (!scn->scn_async_destroying && zfs_free_leak_on_eio &&
+	if (dp->dp_free_dir != NULL && !scn->scn_async_destroying &&
+	    zfs_free_leak_on_eio &&
 	    (dsl_dir_phys(dp->dp_free_dir)->dd_used_bytes != 0 ||
 	    dsl_dir_phys(dp->dp_free_dir)->dd_compressed_bytes != 0 ||
 	    dsl_dir_phys(dp->dp_free_dir)->dd_uncompressed_bytes != 0)) {
@@ -1543,7 +1545,7 @@ dsl_scan_sync(dsl_pool_t *dp, dmu_tx_t *
 		    -dsl_dir_phys(dp->dp_free_dir)->dd_compressed_bytes,
 		    -dsl_dir_phys(dp->dp_free_dir)->dd_uncompressed_bytes, tx);
 	}
-	if (!scn->scn_async_destroying) {
+	if (dp->dp_free_dir != NULL && !scn->scn_async_destroying) {
 		/* finished; verify that space accounting went to zero */
 		ASSERT0(dsl_dir_phys(dp->dp_free_dir)->dd_used_bytes);
 		ASSERT0(dsl_dir_phys(dp->dp_free_dir)->dd_compressed_bytes);


More information about the svn-src-all mailing list