svn commit: r296443 - stable/10/sys/dev/usb/net

[Hans Petter Selasky]

Author: hselasky
Date: Mon Mar  7 09:35:20 2016
New Revision: 296443
URL: https://svnweb.freebsd.org/changeset/base/296443

Log:
  MFC r295608:
  Fix variable assignment inside if-clause in the smsc driver.
  Found by D5245 / PVS.

Modified:
  stable/10/sys/dev/usb/net/if_smsc.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/usb/net/if_smsc.c
==============================================================================
--- stable/10/sys/dev/usb/net/if_smsc.c	Mon Mar  7 09:00:27 2016	(r296442)
+++ stable/10/sys/dev/usb/net/if_smsc.c	Mon Mar  7 09:35:20 2016	(r296443)
@@ -1341,7 +1341,7 @@ smsc_chip_init(struct smsc_softc *sc)
 	/* Reset the PHY */
 	smsc_write_reg(sc, SMSC_PM_CTRL, SMSC_PM_CTRL_PHY_RST);
 
-	if ((err = smsc_wait_for_bits(sc, SMSC_PM_CTRL, SMSC_PM_CTRL_PHY_RST) != 0)) {
+	if ((err = smsc_wait_for_bits(sc, SMSC_PM_CTRL, SMSC_PM_CTRL_PHY_RST)) != 0) {
 		smsc_warn_printf(sc, "timed-out waiting for phy reset to complete\n");
 		goto init_failed;
 	}