svn commit: r296320 - in head/sys: kern sys

Hans Petter Selasky hps at selasky.org
Thu Mar 3 12:44:18 UTC 2016


On 03/03/16 13:41, Konstantin Belousov wrote:
>> The "td_slpcallout" is not drained anywhere, last time I checked. Does
>> >this change require draining of the td_slpcallout in case the thread
>> >immediately is exited/destroyed?
> callout_stop_safe(CS_MIGRBLOCK) is enough in this case.  td_slpcallout
> is only reset from the sleepq code, and the fragment you cited is enough
> to guarantee that no spurious wakeup of the unrelated time-bound sleep
> happens, because TDF_TIMOFAIL flag cannot be cleared after that.
>
> Struct thread memory is type-stable, so callout subsystem never operates
> on the freed memory from td_slpcallout.
>
>

Thank you.

--HPS


More information about the svn-src-all mailing list