svn commit: r302210 - head/sys/fs/nfsclient
Konstantin Belousov
kostikbel at gmail.com
Sun Jun 26 16:09:12 UTC 2016
On Sun, Jun 26, 2016 at 10:54:44AM -0500, Benjamin Kaduk wrote:
> On Sun, Jun 26, 2016 at 9:18 AM, Konstantin Belousov <kib at freebsd.org>
> wrote:
>
> > Author: kib
> > Date: Sun Jun 26 14:18:28 2016
> > New Revision: 302210
> > URL: https://svnweb.freebsd.org/changeset/base/302210
> >
> > Log:
> > Clean other flags in ncl_inactive, only. Add comment explaining why
> > other
> > flags should be unset.
> >
> [...]
>
> > +
> > + /*
> > + * NMODIFIED means that there might be dirty/stale buffers
> > + * associated with the NFS vnode. None of the other flags are
> > + * meaningful after the vnode is unused.
> > + */
> > + np->n_flag &= NMODIFIED;
> >
>
> Maybe I am confused, but the commit message reads like this should be '=',
> not '&='.
The line clears all flags except NMODIFIED, and lefts the NMODIFIED flag
intact (it could have been not set there, after all).
More information about the svn-src-all
mailing list