svn commit: r302094 - in head/sys: compat/freebsd32 kern

John Baldwin jhb at freebsd.org
Thu Jun 23 16:55:07 UTC 2016


On Thursday, June 23, 2016 12:39:48 AM Brooks Davis wrote:
> On Wed, Jun 22, 2016 at 05:09:34PM -0700, John Baldwin wrote:
> > On Wednesday, June 22, 2016 09:15:59 PM Brooks Davis wrote:
> > > Author: brooks
> > > Date: Wed Jun 22 21:15:59 2016
> > > New Revision: 302094
> > > URL: https://svnweb.freebsd.org/changeset/base/302094
> > > 
> > > Log:
> > >   Mark the pipe() system call as COMPAT10.
> > >   
> > >   As of r302092 libc uses pipe2() with a zero flags value instead of pipe().
> > >   
> > >   Commit with regenerated files and implementation to follow.
> > 
> > This breaks the build on at least i386 because other ABIs depend on being
> > able to call sys_pipe directly.  You should at least add COMPAT_FREEBSD10
> > to GENERIC on architectures that shipped a 10.x release.  That will fix the
> > build breakage on i386, but it's also the policy we follow for all the other
> > compat knobs.
> 
> It was actually that sys_pipe() was renamed by the COMPAT10 tag.  I've
> copied the implementation to a svr4_pipe().

Thanks, my bad for jumping the gun on assuming FREEBSD10 was missing from
GENERIC.

-- 
John Baldwin


More information about the svn-src-all mailing list