svn commit: r301959 - head/sys/kern

[Bryan Drewery]

On 6/17/2016 9:51 AM, Bryan Drewery wrote:
> On 6/16/2016 11:13 PM, Konstantin Belousov wrote:
>> On Thu, Jun 16, 2016 at 10:17:19AM -0700, Conrad Meyer wrote:
>>> style(9) nit: /* FALLTHROUGH */
>>
>> FALLTHROUGH is only applicable when there are executable statements for
>> both cases, and first sequence of statements does not end in break.
>> Look at the switch() example right after the FALLTHROUGH requirement
>> in the style(9), which shows case '?'.
>>
> 
> Yes the example shows code in both cases, but the text about it is more
> strict "Elements in a switch statement that cascade should have a
> FALLTHROUGH comment."
> 

My personal opinion does agree with your interpretation.  I think we
should clarify style.9 about when to use FALLTHROUGH.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20160617/a12a23e6/attachment.sig>