svn commit: r301959 - head/sys/kern

[Ian Lepore]

On Thu, 2016-06-16 at 10:43 -0700, Ngie Cooper wrote:
> > On Jun 16, 2016, at 10:17, Conrad Meyer <cem at freebsd.org> wrote:
> > 
> > > On Thu, Jun 16, 2016 at 4:58 AM, Konstantin Belousov <
> > > kib at freebsd.org> wrote:
> > > --- head/sys/kern/kern_thread.c Thu Jun 16 11:55:24 2016       
> > >  (r301958)
> > > +++ head/sys/kern/kern_thread.c Thu Jun 16 11:58:46 2016       
> > >  (r301959)
> > > @@ -669,11 +669,6 @@ weed_inhib(int mode, struct thread *td2,
> > >                        wakeup_swapper |= sleepq_abort(td2,
> > > EINTR);
> > >                break;
> > >        case SINGLE_BOUNDARY:
> > > -               if (TD_IS_SUSPENDED(td2) && (td2->td_flags &
> > > TDF_BOUNDARY) == 0)
> > > -                       wakeup_swapper |=
> > > thread_unsuspend_one(td2, p, false);
> > > -               if (TD_ON_SLEEPQ(td2) && (td2->td_flags &
> > > TDF_SINTR) != 0)
> > > -                       wakeup_swapper |= sleepq_abort(td2,
> > > ERESTART);
> > > -               break;
> > 
> > style(9) nit: /* FALLTHROUGH */
> > 
> Also, coverity will complain about the missing break unless that's
> there...
> 

If coverity complains about

  case 1:
  case 2:
    statements;
    break;

then it is coverity that needs to be fixed.

-- Ian

> > Best,
> > Conrad
> > 
> > >        case SINGLE_NO_EXIT:
> > >                if (TD_IS_SUSPENDED(td2) && (td2->td_flags &
> > > TDF_BOUNDARY) == 0)
> > >                        wakeup_swapper |=
> > > thread_unsuspend_one(td2, p, false);
> > 
> 
>