svn commit: r301696 - head/contrib/atf

[Ed Schouten]

Author: ed
Date: Wed Jun  8 20:54:56 2016
New Revision: 301696
URL: https://svnweb.freebsd.org/changeset/base/301696

Log:
  Don't let ATF call basename() and dirname() in a non-standard way.
  
  POSIX basename() and dirname() are allowed to overwrite the input
  buffer. The advantage of implementing it that way is that the functions
  can be thread-safe, as they don't store the result in a global buffer.
  
  It looks like ATF wants to call basename() and dirname() in the
  non-standard way where the argument is of type "const char *". This
  change disables the calls to basename() and dirname(), which only seems
  to affect the formatting of some rare debug/error messages.
  
  Reviewed by:	ngie
  Differential Revision:	https://reviews.freebsd.org/D6627

Modified:
  head/contrib/atf/config.h

Modified: head/contrib/atf/config.h
==============================================================================
--- head/contrib/atf/config.h	Wed Jun  8 20:47:25 2016	(r301695)
+++ head/contrib/atf/config.h	Wed Jun  8 20:54:56 2016	(r301696)
@@ -2,10 +2,10 @@
 /* config.h.in.  Generated from configure.ac by autoheader.  */
 
 /* Define to 1 if basename takes a constant pointer */
-#define HAVE_CONST_BASENAME 1
+/* #undef HAVE_CONST_BASENAME */
 
 /* Define to 1 if dirname takes a constant pointer */
-#define HAVE_CONST_DIRNAME 1
+/* #undef HAVE_CONST_DIRNAME */
 
 /* Define to 1 if you have the <dlfcn.h> header file. */
 #define HAVE_DLFCN_H 1