svn commit: r303484 - head/usr.bin/indent

Pedro Giffuni pfg at FreeBSD.org
Fri Jul 29 18:10:20 UTC 2016



On 07/29/16 11:24, Benjamin Kaduk wrote:
> On Fri, Jul 29, 2016 at 11:20 AM, Benjamin Kaduk <bjkfbsd at gmail.com
> <mailto:bjkfbsd at gmail.com>> wrote:
>
>     On Fri, Jul 29, 2016 at 11:17 AM, Pedro F. Giffuni <pfg at freebsd.org
>     <mailto:pfg at freebsd.org>> wrote:
>
>         Author: pfg
>         Date: Fri Jul 29 16:17:54 2016
>         New Revision: 303484
>         URL: https://svnweb.freebsd.org/changeset/base/303484
>
>         Log:
>           indent(1): Fix breakage caused by single comment following "else".
>
>           indent(1) simply wasn't taught that "else" may be followed by
>         a comment
>           without any opening brace anywhere on the line, so it was very
>         confused
>           in such cases.
>
>
>     Wrong commit message?  I see no 'else' in this change.
>     (I guess core's guidance is to revert and recommit with correct
>     message, these days.)
>
>
> Nevermind, I think I see what's going on here, now.
>

No problem. It would be great to have more eyes helping review the
changes here:

https://github.com/pstef/freebsd_indent/commits/master

I only got started with a first batch of them.

Regards,

Pedro.


More information about the svn-src-all mailing list