svn commit: r303338 - head/sys/dev/vt

[Ed Maste]

On 26 July 2016 at 12:27, Ed Schouten <ed at nuxi.nl> wrote:
> Hi Ed,
>
> 2016-07-26 17:34 GMT+02:00 Ed Maste <emaste at freebsd.org>:
>>                 if (vw == vd->vd_curwindow) {
>> +                       mtx_lock(&Giant);
>>                         kbd = kbd_get_keyboard(vd->vd_keyboard);
>>                         if (kbd != NULL)
>>                                 vt_save_kbd_state(vw, kbd);
>> +                       mtx_unlock(&Giant);
>>                 }
>
> Would it make sense to put an mtx_assert(&Giant, MA_OWNED) in
> kbd_get_keyboard()?

Yes, I made that change locally and also intend to review
kbd_get_keyboard's callers. I didn't commit it to HEAD right away to
avoid mass breakage if there's missing locking.