svn commit: r302985 - head/sys/geom/label

[Maxim Sobolev]

Andrey, would you mind leaving your comments in the phabricator so that the
Mikhail (original contributor of the patch) could work on an improved
version? You might be correct about the abs(), I've overlooked that, but
the fs_fsize math is just copied over the previous code as far as I can
tell. So if it worked with the strict comparison, it should also work with
relaxed bound one.

https://reviews.freebsd.org/D6208

Thanks!

-Max

On Mon, Jul 18, 2016 at 1:18 PM, Andrey V. Elsukov <bu7cher at yandex.ru>
wrote:

> On 18.07.16 22:37, Maxim Sobolev wrote:
> > Well, this looks to me exactly what I am talking about. With this change
> > we are only allowing underlying provider to be *slighly* bigger than the
> > UFS size. So as I said it's pretty harmless to do so, or at least I
>
> So, this isn't true.
> 1. You use abs() in the macro - it can be less or bigger.
> 2. fs_fsize is size of frag blocks, so use it as divider looks incorrect.
>
> --
> WBR, Andrey V. Elsukov
>
>