svn commit: r302324 - head/lib/libc/locale

[Jung-uk Kim]

On 07/15/16 02:22 AM, Kubilay Kocak wrote:
> On 15/07/2016 4:19 PM, Jung-uk Kim wrote:
>> On 07/03/16 11:00 AM, Baptiste Daroussin wrote:
>>> Author: bapt
>>> Date: Sun Jul  3 15:00:12 2016
>>> New Revision: 302324
>>> URL: https://svnweb.freebsd.org/changeset/base/302324
>>>
>>> Log:
>>>   Fix a bad test resulting in a segfault with ISO-8859-5 locales
>>>   
>>>   Reported by:	Lauri Tirkkonen from Illumos
>>>   Approved by:	re@ (gjb)
>>>
>>> Modified:
>>>   head/lib/libc/locale/collate.c
>>>
>>> Modified: head/lib/libc/locale/collate.c
>>> ==============================================================================
>>> --- head/lib/libc/locale/collate.c	Sun Jul  3 11:45:54 2016	(r302323)
>>> +++ head/lib/libc/locale/collate.c	Sun Jul  3 15:00:12 2016	(r302324)
>>> @@ -310,7 +310,7 @@ _collate_lookup(struct xlocale_collate *
>>>  	if ((sptr = *state) != NULL) {
>>>  		*pri = *sptr;
>>>  		sptr++;
>>> -		if ((sptr == *state) || (sptr == NULL))
>>> +		if ((sptr == *state) || (*sptr == 0))
>>>  			*state = NULL;
>>>  		else
>>>  			*state = sptr;
>>
>> I had a serious regression with ko_KR.UTF-8 locale after this commit.
>> MATE is unusable because mate-panel is busy looping and eating 100% CPU.
>>  GNOME 3 does not start at all, i.e., nothing but mouse cursor on black
>> screen.  After reverting this commit, everything is back to normal.
>> Please investigate.  IMHO, this must be fixed before 11.0-BETA2 build.
>>
>> Thanks,
>>
>> Jung-uk Kim
>>
> 
> Please report a bug so it can be tracked and not forgotten:
> 
> Add re@ and original committer to cc
> Set mfc-stable11 to ?
> Add keyword: regression

Done:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211135

Jung-uk Kim

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20160715/008b4384/attachment.sig>