svn commit: r295051 - head/sys/dev/ixl

Steven Hartland steven.hartland at multiplay.co.uk
Sat Jan 30 01:15:19 UTC 2016


This should have referenced https://reviews.freebsd.org/D5106

On 29/01/2016 21:06, Steven Hartland wrote:
> Author: smh
> Date: Fri Jan 29 21:06:59 2016
> New Revision: 295051
> URL: https://svnweb.freebsd.org/changeset/base/295051
>
> Log:
>    Fix phy interrupts setup for ixl
>    
>    Fix the inverted set of interrupts being used as the mask for ixl.
>    
>    Without this ixl devices fail to detect link state changes.
>    
>    Reviewed by:	erj, sbruno
>    MFC after:	2 days
>    Sponsored by:	Multiplay
>
> Modified:
>    head/sys/dev/ixl/if_ixl.c
>
> Modified: head/sys/dev/ixl/if_ixl.c
> ==============================================================================
> --- head/sys/dev/ixl/if_ixl.c	Fri Jan 29 18:43:51 2016	(r295050)
> +++ head/sys/dev/ixl/if_ixl.c	Fri Jan 29 21:06:59 2016	(r295051)
> @@ -674,9 +674,9 @@ ixl_attach(device_t dev)
>   	}
>   
>   	/* Limit phy interrupts to link and modules failure */
> -	error = i40e_aq_set_phy_int_mask(hw,
> -	    I40E_AQ_EVENT_LINK_UPDOWN | I40E_AQ_EVENT_MODULE_QUAL_FAIL, NULL);
> -        if (error)
> +	error = i40e_aq_set_phy_int_mask(hw, ~(I40E_AQ_EVENT_LINK_UPDOWN |
> +		I40E_AQ_EVENT_MODULE_QUAL_FAIL), NULL);
> +	if (error)
>   		device_printf(dev, "set phy mask failed: %d\n", error);
>   
>   	/* Get the bus configuration and set the shared code */
>



More information about the svn-src-all mailing list