svn commit: r294241 - stable/9/lib/libc/rpc

Garrett Cooper ngie at FreeBSD.org
Mon Jan 18 03:51:39 UTC 2016


Author: ngie
Date: Mon Jan 18 03:51:38 2016
New Revision: 294241
URL: https://svnweb.freebsd.org/changeset/base/294241

Log:
  MFstable/10 r294239:
  
  MFC r293704:
  
  Fix theoretical leak of netconfig(3) resources in svcunix_create(..)
  
  In the event that the getconfig(3) call in svcunix_create is partly successful,
  some of the netconfig(3) resources allocated might be leaked if the call returns
  NULL as endnetconfig(3) wasn't called explicitly in that case. Ensure that the
  resources are fully cleaned up by going to the `done` label, which will call
  endnetconfig(3) for us.
  
  Submitted by: Miles Ohlrich <miles.ohlrich at isilon.com>

Modified:
  stable/9/lib/libc/rpc/rpc_soc.c
Directory Properties:
  stable/9/   (props changed)
  stable/9/lib/   (props changed)
  stable/9/lib/libc/   (props changed)

Modified: stable/9/lib/libc/rpc/rpc_soc.c
==============================================================================
--- stable/9/lib/libc/rpc/rpc_soc.c	Mon Jan 18 03:49:57 2016	(r294240)
+++ stable/9/lib/libc/rpc/rpc_soc.c	Mon Jan 18 03:51:38 2016	(r294241)
@@ -525,7 +525,7 @@ svcunix_create(sock, sendsize, recvsize,
 			break;
 	}
 	if (nconf == NULL)
-		return(xprt);
+		goto done;
 
 	if ((sock = __rpc_nconf2fd(nconf)) < 0)
 		goto done;


More information about the svn-src-all mailing list