svn commit: r294239 - stable/10/lib/libc/rpc

[Garrett Cooper]

Author: ngie
Date: Mon Jan 18 03:47:46 2016
New Revision: 294239
URL: https://svnweb.freebsd.org/changeset/base/294239

Log:
  MFC r293704:
  
  Fix theoretical leak of netconfig(3) resources in svcunix_create(..)
  
  In the event that the getconfig(3) call in svcunix_create is partly successful,
  some of the netconfig(3) resources allocated might be leaked if the call returns
  NULL as endnetconfig(3) wasn't called explicitly in that case. Ensure that the
  resources are fully cleaned up by going to the `done` label, which will call
  endnetconfig(3) for us.
  
  Submitted by: Miles Ohlrich <miles.ohlrich at isilon.com>

Modified:
  stable/10/lib/libc/rpc/rpc_soc.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/lib/libc/rpc/rpc_soc.c
==============================================================================
--- stable/10/lib/libc/rpc/rpc_soc.c	Mon Jan 18 00:07:04 2016	(r294238)
+++ stable/10/lib/libc/rpc/rpc_soc.c	Mon Jan 18 03:47:46 2016	(r294239)
@@ -525,7 +525,7 @@ svcunix_create(sock, sendsize, recvsize,
 			break;
 	}
 	if (nconf == NULL)
-		return(xprt);
+		goto done;
 
 	if ((sock = __rpc_nconf2fd(nconf)) < 0)
 		goto done;