svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi
Steven Hartland
steven at multiplay.co.uk
Thu Jan 14 16:51:07 UTC 2016
On 14/01/2016 15:55, John Baldwin wrote:
> On Thursday, January 14, 2016 01:27:51 AM NGie Cooper wrote:
>>> On Jan 14, 2016, at 01:22, Steven Hartland <smh at FreeBSD.org> wrote:
>>>
>>> Author: smh
>>> Date: Thu Jan 14 09:22:01 2016
>>> New Revision: 293903
>>> URL: https://svnweb.freebsd.org/changeset/base/293903
>>>
>>> Log:
>>> Fix GCC warnings causing build failure after r293724
>>>
>>> Disable some compiler warnings for GCC (non-standard compiler) fixing
>>> build failures introduced by r293724, which enabled WARNS in the EFI boot
>>> code, when compiling with none standard compiler (GCC).
>> Disabling warnings is wrong. Here’s how arm could be fixed:
>>
>> $ svn diff sys/boot/
>> Index: sys/boot/common/bootstrap.h
>> ===================================================================
>> --- sys/boot/common/bootstrap.h (revision 293877)
>> +++ sys/boot/common/bootstrap.h (working copy)
>> @@ -32,6 +32,7 @@
>> #include <sys/types.h>
>> #include <sys/queue.h>
>> #include <sys/linker_set.h>
>> +#include <time.h>
>>
>> /*
>> * Generic device specifier; architecture-dependant
>> @@ -332,12 +333,8 @@
>> extern struct arch_switch archsw;
>>
>> /* This must be provided by the MD code, but should it be in the archsw? */
>> -void delay(int delay);
>> -
> The comment seems to be related to delay() so it should perhaps go as well?
>
delay is actually provided by libefi but nothing else in sys/boot, so I
cant see why this was ever needed, possibly a hang over?
More information about the svn-src-all
mailing list